From ca0e352d559a78a8674cd5378cb62709bacc93ff Mon Sep 17 00:00:00 2001
From: Daniel Tsai <idaniel.twc@gmail.com>
Date: Wed, 13 Mar 2024 09:29:03 -0400
Subject: [PATCH] Fix/add failure behavior #266 (#267)

This MR addresses the behavior mismatch mentioned in
https://github.com/etcd-cpp-apiv3/etcd-cpp-apiv3/issues/266
Have passed the `EtcdSyncTest`
---
 src/v3/AsyncGRPC.cpp | 4 ++--
 tst/EtcdSyncTest.cpp | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/v3/AsyncGRPC.cpp b/src/v3/AsyncGRPC.cpp
index bc1dcdd..e211392 100644
--- a/src/v3/AsyncGRPC.cpp
+++ b/src/v3/AsyncGRPC.cpp
@@ -994,9 +994,9 @@ etcdv3::AsyncSetAction::AsyncSetAction(etcdv3::ActionParameters&& params,
   // backwards compatibility
   txn.add_success_range(parameters.key);
   if (create) {
-    txn.add_failure_put(parameters.key, parameters.value, parameters.lease_id);
-  } else {
     txn.add_failure_range(parameters.key);
+  } else {
+    txn.add_failure_put(parameters.key, parameters.value, parameters.lease_id);
   }
   response_reader =
       parameters.kv_stub->AsyncTxn(&context, *txn.txn_request, &cq_);
diff --git a/tst/EtcdSyncTest.cpp b/tst/EtcdSyncTest.cpp
index e588c28..a0ac32b 100644
--- a/tst/EtcdSyncTest.cpp
+++ b/tst/EtcdSyncTest.cpp
@@ -18,7 +18,7 @@ TEST_CASE("sync operations") {
   // add
   CHECK(0 == etcd.add("/test/key1", "42").error_code());
   CHECK(etcd::ERROR_KEY_ALREADY_EXISTS ==
-        etcd.add("/test/key1", "42").error_code());  // Key already exists
+        etcd.add("/test/key1", "41").error_code());  // Key already exists
   CHECK("42" == etcd.get("/test/key1").value().as_string());
 
   // modify